Comments on: For-Loop Defeats Copy/Paste http://www.gamepoetry.com/blog/2009/04/23/for-loop-defeats-copy-paste/ The art, science and business of independent game development Sun, 25 Jul 2010 17:51:13 -0700 http://wordpress.org/?v=2.8.4 hourly 1 By: urbansquall http://www.gamepoetry.com/blog/2009/04/23/for-loop-defeats-copy-paste/comment-page-1/#comment-2428 urbansquall Sun, 26 Apr 2009 07:12:11 +0000 http://www.gamepoetry.com/blog/?p=543#comment-2428 <p>Very true. :)</p> Very true. :)

]]> By: mpowers http://www.gamepoetry.com/blog/2009/04/23/for-loop-defeats-copy-paste/comment-page-1/#comment-2425 mpowers Sun, 26 Apr 2009 05:34:16 +0000 http://www.gamepoetry.com/blog/?p=543#comment-2425 <p>Instead of var neighbors : Array = [ map.getTile( m_currentX - 1, m_currentY ), map.getTile( m_currentX + 1, m_currentY ), map.getTile( m_currentX, m_currentY + 1), map.getTile( m_currentX, m_currentY - 1 ) ];</p> <p>you're may be even better off with var neighborCoords : Array = [ {x:-1, y:0}, {x:1, y:0}, {x:0, y:-1}, {x:0, y:1} ];</p> <p>for( var n : int = 0; n < neighbors.length; n++ ) { var coord: Object = neighborCoords[n]; var neighbor : Tile = map.getTile( m_currentX + coord.x, m_currentY + coord.y );</p> <p>...</p> <p>You repeat yourself even less, this way.</p> Instead of var neighbors : Array = [ map.getTile( m_currentX - 1, m_currentY ), map.getTile( m_currentX + 1, m_currentY ), map.getTile( m_currentX, m_currentY + 1), map.getTile( m_currentX, m_currentY - 1 ) ];

you’re may be even better off with var neighborCoords : Array = [ {x:-1, y:0}, {x:1, y:0}, {x:0, y:-1}, {x:0, y:1} ];

for( var n : int = 0; n < neighbors.length; n++ ) { var coord: Object = neighborCoords[n]; var neighbor : Tile = map.getTile( m_currentX + coord.x, m_currentY + coord.y );

…

You repeat yourself even less, this way.

]]> By: urbansquall http://www.gamepoetry.com/blog/2009/04/23/for-loop-defeats-copy-paste/comment-page-1/#comment-2362 urbansquall Fri, 24 Apr 2009 14:53:21 +0000 http://www.gamepoetry.com/blog/?p=543#comment-2362 <p>@Colby: Haha.. :)</p> <p>@Snurre: I used 'n' because colliding indexes are more trouble then they are worth. :)</p> @Colby: Haha.. :)

@Snurre: I used ‘n’ because colliding indexes are more trouble then they are worth. :)

]]> By: Snurre http://www.gamepoetry.com/blog/2009/04/23/for-loop-defeats-copy-paste/comment-page-1/#comment-2361 Snurre Fri, 24 Apr 2009 14:34:56 +0000 http://www.gamepoetry.com/blog/?p=543#comment-2361 <p>You're absolutely right. I wonder why you use 'n' instead of 'i' as the index, but i guess that because of the neighbors?</p> <p>Be sure to see this post http://blog.vortixgames.com/factory for more info on patterns.</p> You’re absolutely right. I wonder why you use ‘n’ instead of ‘i’ as the index, but i guess that because of the neighbors?

Be sure to see this post http://blog.vortixgames.com/factory for more info on patterns.

]]> By: Colbycheeze http://www.gamepoetry.com/blog/2009/04/23/for-loop-defeats-copy-paste/comment-page-1/#comment-2347 Colbycheeze Fri, 24 Apr 2009 06:25:46 +0000 http://www.gamepoetry.com/blog/?p=543#comment-2347 <p>I have a feeling you were thinking of me when you wrote this :D</p> I have a feeling you were thinking of me when you wrote this :D

]]>